I don't know if Saint John has a single stand-out iconic building per se - our architectural strength is really in the overall collection of smaller-scale historic buildings adding up to something greater than the sum of their parts. If I was pressed to pick something though, it would probably be one of our historic churches, one of the following:
Trinity Anglican Church
Source
Cathedral of the Immaculate Conception (Roman Catholic)
Source